Fail the run-pr-external_checks if it can not find cmssw-tool-conf#2567
Fail the run-pr-external_checks if it can not find cmssw-tool-conf#2567
Conversation
|
A new Pull Request was created by @smuzaffar for branch master. @akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
|
cms-bot internal usage |
|
please test with cms-sw/cmsdist#10074 with current change the external checks should fail as they will not be able to find cmssw-tools |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a97d/48106/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
Pull request #2567 was updated. |
|
please test with cms-sw/cmsdist#10072 |
|
please test with cms-sw/cmsdist#10072 |
|
Pull request #2567 was updated. |
|
+externals https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a97d/48117/summary.html now properly find the cmssw tools and report for any relocation issues |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Failed Tests: UnitTests Unit TestsI found 2 errors in the following unit tests: ---> test test_DavixReadV_http had ERRORS ---> test test_DavixRead_http had ERRORS Comparison SummarySummary:
|
run-pr-external_checks.shis silently failing since we move tocmssw-toolsinstead ofcmssw-tool-conf. This change makes sure that external checks are marked failed if they can not find cmssw-tool-conf.